chore: update RNTester Cocoapods to 1.13#41248
Closed
okwasniewski wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
added
CLA Signed
okwasniewski
changed the title
okwasniewski
force-pushed
the
okwasniewski/chore/gemfile
branch
from
83c7d37 to
6e0388b
Compare
Contributor
Author
|
When I removed the root Gemfile CI failed so it looks like its still needed |
Base commit: 53a2742 |
Contributor
|
Yeah, it's not a simple removal. It should go, but there are other cleanup that are required to remove it properly! |
okwasniewski
force-pushed
the
okwasniewski/chore/gemfile
branch
from
6e0388b to
c028923
Compare
Contributor
Author
|
@cipolleschi Can we merge it without removing the root one? |
okwasniewski
force-pushed
the
okwasniewski/chore/gemfile
branch
from
c028923 to
9aadebd
Compare
Contributor
|
yes sure. I thought I had already imported this one. Sorry. |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @okwasniewski in b955fc2. When will my fix make it into a release? | Upcoming Releases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the internal version of cocoapods to 1.13, template already uses this version. I've also removed the root folder Gemfile as it's not necessary anymore.
Changelog:
[INTERNAL] [CHANGED] - Update RNTester Cocoapods to 1.13
Test Plan:
Check if cocoapods installs correctly by running:
bundle installbundle exec pod install